Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into master #4

Merged
merged 41 commits into from
Feb 6, 2024
Merged

Merge develop into master #4

merged 41 commits into from
Feb 6, 2024

Conversation

tdejoigny-ledger
Copy link

Jira ticket B2CA-1419

coderofstuff and others added 30 commits November 10, 2023 17:57
Get elements from the standard app and apply to fuzzing here
When getting the SPK for P2SH, ensure that script_len is always 0x20
- Fix the fuzzer so that it's standardized again
- Fix validation of multisig addresses
Although these were from the boilerplate, we don't really need them
- 1st definition in SDK
- 2nd definition in the Application (same filename also)
- Fix dependencies (header files, definitions)
BC2A-1408: Remove duplicate apdu_parser
Merge in Ledger's changes in their "develop"
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@200e11d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   80.56%           
=======================================
  Files           ?        7           
  Lines           ?      391           
  Branches        ?        0           
=======================================
  Hits            ?      315           
  Misses          ?       76           
  Partials        ?        0           
Flag Coverage Δ
unittests 80.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdejoigny-ledger tdejoigny-ledger merged commit 52ab853 into main Feb 6, 2024
90 checks passed
lemois-1337 pushed a commit to lemois-1337/app-karlsen that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants